Orders which did not match off 100%

Development Counterparty
1

I was having a look at an order match. I’m not sure why it wasn’t 100% filled. Is this a rounding error that will be fixed?

Give 0.085 XBTC get 10 XCP<br />sqlite> select * from orders where tx_index=5265;<br />5265|667f1bfb97499e9450c81d9bf0c8914442938a634e6d22b74ee0f5a0dd2dd86c|289101|1G38xjStnniS5Pjh2jryQeCMisu1EwnjYe|XBTC|8500000|1|XCP|1000000000|118|1440|290541|0|0|10000|10000|valid<br /><br />Give 10 XCP get 0.085 XBTC<br />sqlite> select * from orders where tx_index=5281;<br />5281|5317f9078208edc792db754bc3085c52364d8a5a5eb4fd3df05cfbe0ada4d2ba|289287|1xXCPxBC7kRkkYnTeS4ARk3YYwLF5Y5QT|XCP|1000000000|118|XBTC|8500000|1|240|289527|0|0|10000|10000|valid<br /><br />Order match<br />sqlite> select * from order_matches where tx1_index=5281;<br />667f1bfb97499e9450c81d9bf0c8914442938a634e6d22b74ee0f5a0dd2dd86c5317f9078208edc792db754bc3085c52364d8a5a5eb4fd3df05cfbe0ada4d2ba|5265|667f1bfb97499e9450c81d9bf0c8914442938a634e6d22b74ee0f5a0dd2dd86c|1G38xjStnniS5Pjh2jryQeCMisu1EwnjYe|5281|5317f9078208edc792db754bc3085c52364d8a5a5eb4fd3df05cfbe0ada4d2ba|1xXCPxBC7kRkkYnTeS4ARk3YYwLF5Y5QT|XBTC|8499999|XCP|999999882|289101|289287|1440|240|289297|completed

2

[quote author=Global_trade_repo link=topic=171.msg1171#msg1171 date=1394447461]
I was having a look at an order match. I’m not sure why it wasn’t 100% filled. Is this a rounding error that will be fixed?

Give 0.085 XBTC get 10 XCP<br />sqlite> select * from orders where tx_index=5265;<br />5265|667f1bfb97499e9450c81d9bf0c8914442938a634e6d22b74ee0f5a0dd2dd86c|289101|1G38xjStnniS5Pjh2jryQeCMisu1EwnjYe|XBTC|8500000|1|XCP|1000000000|118|1440|290541|0|0|10000|10000|valid<br /><br />Give 10 XCP get 0.085 XBTC<br />sqlite> select * from orders where tx_index=5281;<br />5281|5317f9078208edc792db754bc3085c52364d8a5a5eb4fd3df05cfbe0ada4d2ba|289287|1xXCPxBC7kRkkYnTeS4ARk3YYwLF5Y5QT|XCP|1000000000|118|XBTC|8500000|1|240|289527|0|0|10000|10000|valid<br /><br />Order match<br />sqlite> select * from order_matches where tx1_index=5281;<br />667f1bfb97499e9450c81d9bf0c8914442938a634e6d22b74ee0f5a0dd2dd86c5317f9078208edc792db754bc3085c52364d8a5a5eb4fd3df05cfbe0ada4d2ba|5265|667f1bfb97499e9450c81d9bf0c8914442938a634e6d22b74ee0f5a0dd2dd86c|1G38xjStnniS5Pjh2jryQeCMisu1EwnjYe|5281|5317f9078208edc792db754bc3085c52364d8a5a5eb4fd3df05cfbe0ada4d2ba|1xXCPxBC7kRkkYnTeS4ARk3YYwLF5Y5QT|XBTC|8499999|XCP|999999882|289101|289287|1440|240|289297|completed
[/quote]

They would be perfectly matched only if they had exactly the same [tt]fee_required[/tt]/[tt]fee_provided[/tt]. Did they?

3
4

I just fixed this issue with a new commit to [tt]develop[/tt], in which the change to the rounding rules is only active on [tt]testnet[/tt] for now. The solution is a bit hackish, is all.

See https://github.com/PhantomPhreak/counterpartyd/commit/d7bd4d1344285fe79667752f5c2bd853457b7d07.

5

Thanks for having a look PhantomPhreak, I performed a test on testnet where the ratio is a repeating number and as expected the orders matched exactly.

6

Sorry, I didn’t check properly. The orders were not filled 100%. Is it active in testnet on the servers running Counterwallet?

Order id: 2042


edit: order id not order match id

7

[quote author=Global_trade_repo link=topic=171.msg1560#msg1560 date=1395626331]
Sorry, I didn’t check properly. The orders were not filled 100%. Is it active in testnet on the servers running Counterwallet?

Order id: 2042


edit: order id not order match id
[/quote]

What’s the tx hash of the order?